From 0d60acad51e883c33d604178ecd8ba7ff04c93e3 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Mon, 30 Oct 2023 13:02:47 +0200 Subject: [PATCH 1/5] Prevent throwing error when github server cant respond for auto-update --- src/error-manager/index.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/error-manager/index.js b/src/error-manager/index.js index 8371a5ac..38258707 100644 --- a/src/error-manager/index.js +++ b/src/error-manager/index.js @@ -205,9 +205,16 @@ const initLogger = () => { if (message.level === 'error') { const error = message.data.join(os.EOL) - // Don't open a new issue when can't download differentially - // it would fallback to full download - if (/Cannot download differentially/gi.test(error)) { + /* + * Don't open a new issue when: + * - It can't download differentially it would fallback to full download + * - GitHub server can't respond to the auto-update requests + */ + if ( + /Cannot download differentially/gi.test(error) || + /ERR_CONNECTION_REFUSED/gi.test(error) || + /objects\.githubusercontent\.com/gi.test(error) + ) { return message } From 2c2871a0ab708f5316023940bdf3a778d220b434 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Tue, 14 Nov 2023 13:37:54 +0200 Subject: [PATCH 2/5] Bump version up to v4.15.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 82a23bec..2f8dea9e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bfx-report-electron", - "version": "4.14.0", + "version": "4.15.0", "repository": "https://github.com/bitfinexcom/bfx-report-electron", "description": "Reporting tool", "author": "bitfinex.com", From 7984acdaf46dc2088615b433ff6eab3a62161314 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Tue, 14 Nov 2023 13:38:23 +0200 Subject: [PATCH 3/5] Add changelog for v4.15.0 --- CHANGELOG.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6cfd4714..de432172 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [4.15.0] - 2023-11-15 + +### Added + +- Added `Automated Testing` for electron app binaries. To be sure that the release build of the Electron app has been successful added ability to auto-validate that the application works fine on all OSs (Linux, Mac, Win). PR: [bfx-report-electron#276](https://github.com/bitfinexcom/bfx-report-electron/pull/276) +- Added `Summary by Asset` section for the last 30 days on the new `Summary` for the `Reports` app. Added refreshing for all `Summary` sections on the `Filter` button click. PR: [bfx-report-ui#726](https://github.com/bitfinexcom/bfx-report-ui/pull/726) + +### Fixed + +- Prevented throwing error when `GitHub` server can't respond to auto-update requests. It fixed the following issues: [bfx-report-electron#239](https://github.com/bitfinexcom/bfx-report-electron/issues/239), [bfx-report-electron#264](https://github.com/bitfinexcom/bfx-report-electron/issues/264). PR: [bfx-report-electron#265](https://github.com/bitfinexcom/bfx-report-electron/pull/265) + +### Security + +- Replaced `Lodash` `_get` helper usage all across the app with the corresponding one from the internal library for security reasons. PR: [bfx-report-ui#727](https://github.com/bitfinexcom/bfx-report-ui/pull/727) + ## [4.14.0] - 2023-11-01 ### Added From 1496c2f296c05c3005f4d74172b3a9bd18fbf81e Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Tue, 28 Nov 2023 15:33:13 +0200 Subject: [PATCH 4/5] Update changelog --- CHANGELOG.md | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index de432172..8daabf0b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,16 +7,30 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -## [4.15.0] - 2023-11-15 +## [4.15.0] - 2023-11-29 ### Added -- Added `Automated Testing` for electron app binaries. To be sure that the release build of the Electron app has been successful added ability to auto-validate that the application works fine on all OSs (Linux, Mac, Win). PR: [bfx-report-electron#276](https://github.com/bitfinexcom/bfx-report-electron/pull/276) - Added `Summary by Asset` section for the last 30 days on the new `Summary` for the `Reports` app. Added refreshing for all `Summary` sections on the `Filter` button click. PR: [bfx-report-ui#726](https://github.com/bitfinexcom/bfx-report-ui/pull/726) +- Added ability to sync daily `candles` once per day to reduce the number of sync requests to `BFX API` and as a result improve the situation with the `Rate Limit` restriction. PR: [bfx-reports-framework#334](https://github.com/bitfinexcom/bfx-reports-framework/pull/334) +- Added ability to reference specific user currencies when `candles` sync. The aim is to reduce the amount of requests to the `BFX API` candles endpoint and speed up the sync essentially. Also for better UX, added approximate candles sync time estimation considering the amount of syncing currencies. And set candles limit `20 reqs/min` instead of 30 to go through the `Rate Limit`. PR: [bfx-reports-framework#335](https://github.com/bitfinexcom/bfx-reports-framework/pull/335) + +### Changed + +- Set `10 reqs/min` for `BFX API` `trades` endpoint to help big users go through `Rate Limit` for the `Tax Report`. PR: [bfx-reports-framework#337](https://github.com/bitfinexcom/bfx-reports-framework/pull/337) +- Temporarily hidden `Unrealized Profit` selectors from the new app `Summary` and `Account Balance` reports. PR: [bfx-report-ui#730](https://github.com/bitfinexcom/bfx-report-ui/pull/730) +- Updated TW Translations. PR: [bfx-report-ui#734](https://github.com/bitfinexcom/bfx-report-ui/pull/734) +- Improved `Balance Change` representation in the `Summary by Asset` section. PR: [bfx-report-ui#736](https://github.com/bitfinexcom/bfx-report-ui/pull/736) ### Fixed - Prevented throwing error when `GitHub` server can't respond to auto-update requests. It fixed the following issues: [bfx-report-electron#239](https://github.com/bitfinexcom/bfx-report-electron/issues/239), [bfx-report-electron#264](https://github.com/bitfinexcom/bfx-report-electron/issues/264). PR: [bfx-report-electron#265](https://github.com/bitfinexcom/bfx-report-electron/pull/265) +- Fixed double requests while syncing `candles`. The issue is: when we sync data in the framework mode, candles request can give only one item, in this case, we shouldn't process the part of logic with handling of containing the same timestamps in all items. PR: [bfx-report#343](https://github.com/bitfinexcom/bfx-report/pull/343) +- Fixed getting data from `BFX API` with undefined args. PRs: [bfx-report#344](https://github.com/bitfinexcom/bfx-report/pull/344), [lib-js-util-base#15](https://github.com/bitfinexcom/lib-js-util-base/pull/15) +- Fixed `BFX` auth token refreshing. PR: [bfx-reports-framework#336](https://github.com/bitfinexcom/bfx-reports-framework/pull/336) +- Fixed initial synchronization flow, improved data handling for `Summary` sections. PR: [bfx-report-ui#731](https://github.com/bitfinexcom/bfx-report-ui/pull/731) +- Fixed `candles/trades` requests duplication on `Candles` report refreshing. PR: [bfx-report-ui#732](https://github.com/bitfinexcom/bfx-report-ui/pull/732) +- Fixed synchronization state checking flow and fixed a couple of potential issues that have been spotted in some syncing scenarios. PR: [bfx-report-ui#735](https://github.com/bitfinexcom/bfx-report-ui/pull/735) ### Security From fc341f14b7e27510652342bb32a2034d797b37a8 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Wed, 29 Nov 2023 08:02:22 +0200 Subject: [PATCH 5/5] Update sub-modules --- bfx-report-ui | 2 +- bfx-reports-framework | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bfx-report-ui b/bfx-report-ui index a11ddc2e..c707a10f 160000 --- a/bfx-report-ui +++ b/bfx-report-ui @@ -1 +1 @@ -Subproject commit a11ddc2e57543e83ac17741b7c34d37abe3c2618 +Subproject commit c707a10f3b064fb1ecff263ea7e7a2efc3167fad diff --git a/bfx-reports-framework b/bfx-reports-framework index 3a031952..1c67784d 160000 --- a/bfx-reports-framework +++ b/bfx-reports-framework @@ -1 +1 @@ -Subproject commit 3a0319521ed114321265fbcd70e28decd1d3ca07 +Subproject commit 1c67784d7470a9876f84637f03ddbecb58354e7a