Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect funding ticker fields bidSize and bidPeriod, askSize and askPeriod. frrAmountAvailable is missing #58

Open
2 of 4 tasks
dutu opened this issue Nov 20, 2020 · 0 comments

Comments

@dutu
Copy link

dutu commented Nov 20, 2020

Issue type

  • bug
  • missing functionality
  • performance
  • feature request

Brief description

Funding ticker fields bidSize and bidPeriod are swapped around.
https://github.com/bitfinexcom/bfx-api-node-models/blob/master/lib/funding_ticker.js#L9-L24

Correct position for bidSize is 4 and for bidPeriod is 3.
Similarly, correct position for askSize is 7 and for askPeriod is 6.

Also, field frrAmountAvailable is missing.

Const fields should be:

const fields = {
  symbol: 0,
  frr: 1,
  bid: 2,
  bidSize: 4,
  bidPeriod: 3,
  ask: 5,
  askSize: 7,
  askPeriod: 6,
  dailyChange: 8,
  dailyChangePerc: 9,
  lastPrice: 10,
  volume: 11,
  high: 12,
  low: 13,
  frrAmountAvailable: 14,
}

Reference: https://docs.bitfinex.com/reference#ws-public-ticker

Steps to reproduce

Additional Notes:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant