Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a DIRECT FORM I biquad filter in Gamma #128

Open
jmidt opened this issue Jul 30, 2019 · 1 comment
Open

Implement a DIRECT FORM I biquad filter in Gamma #128

jmidt opened this issue Jul 30, 2019 · 1 comment
Labels
dsp good first issue

Comments

@jmidt
Copy link
Member

jmidt commented Jul 30, 2019

The Gamma dsp library has a biquad filter that uses the direct form II implementation. The problem is that this often pops and cracks when parameters are changed mid-stream. The direct form I should be more resilient to this.

I should probably be made as a separate struct in the util/dsp folder.
@jmidt jmidt added the dsp label Jul 30, 2019
@Sea-Shore-Sahil
Copy link

Hi, I have a Software Methodology class that requires me to contribute to two open-source projects. I am interested in this issue. I saw that the issue was opened in 2019, but there is no update and it still uses Direct Form 2 (BiquadSoftReset.hpp)

Can I contribute if you are looking to implement a direct Form 1 biquad filter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dsp good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmidt @Sea-Shore-Sahil