Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Dependency on mockito-inline #98

Open
jaredsburrows opened this issue Nov 4, 2024 · 0 comments
Open

Remove Redundant Dependency on mockito-inline #98

jaredsburrows opened this issue Nov 4, 2024 · 0 comments

Comments

@jaredsburrows
Copy link

Description:

The project currently includes both mockito-core and mockito-inline dependencies. However, recent versions of mockito-core now include support for inline mocking, making the mockito-inline dependency redundant. This issue proposes removing mockito-inline to clean up dependencies and reduce unnecessary library inclusion.

Reasons to Remove mockito-inline:

  1. Redundant Dependency:

    • Inline mocking capabilities are now built directly into mockito-core, meaning mockito-inline no longer provides additional functionality. Maintaining both dependencies does not add any unique value and effectively makes mockito-inline a no-op in the current setup.
  2. Simplified Dependency Management:

    • By removing mockito-inline, the dependency list becomes cleaner, making it easier to manage and understand the project’s dependencies. Simplified dependencies also make it easier for future contributors to understand the setup without questioning redundant inclusions.
  3. Reduced Risk of Compatibility Issues:

    • Having only the necessary dependencies reduces the risk of conflicts or unexpected behavior due to redundant or unnecessary libraries. This is especially helpful when upgrading dependencies, as it limits potential issues to a single source.
  4. Smaller Build and Faster Compilation:

    • Removing unused dependencies can marginally reduce the build size and may improve build times, especially in larger projects. While the impact may be small, it’s beneficial for optimizing the build process.
  5. Alignment with Best Practices:

Additional Considerations:

To implement this change, mockito-inline should be removed from the dependency configuration. It’s advisable to run the tests after this change to verify that there are no unintended side effects or issues with inline mocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants