Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying math functions #1182

Open
knmcguire opened this issue Jan 5, 2023 · 3 comments
Open

Unifying math functions #1182

knmcguire opened this issue Jan 5, 2023 · 3 comments

Comments

@knmcguire
Copy link
Member

In both the controllers and estimators, math functions are being rewritten as part of the algorithm, but it would be better to separate those all in a unified math .c files or such. We already have math3d.h and such, but some of the latest contributions has not been as consistent.

Here is a list of those functions that qualify, so more can be added in the future:

@whoenig
Copy link
Contributor

whoenig commented Jan 5, 2023

This should also include the data structures. For example, there are multiple different definitions of 3d vectors and quaternions in the code.

@knmcguire
Copy link
Member Author

good point! I changed the title.

@knmcguire knmcguire mentioned this issue Jan 5, 2023
@krichardsson
Copy link
Contributor

Also include definitions of pi (I found 3) :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants