Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDoA3 outlier filter need update for Long Range #1158

Closed
krichardsson opened this issue Nov 28, 2022 · 0 comments · Fixed by #1237
Closed

TDoA3 outlier filter need update for Long Range #1158

krichardsson opened this issue Nov 28, 2022 · 0 comments · Fixed by #1237

Comments

@krichardsson
Copy link
Contributor

krichardsson commented Nov 28, 2022

The TDoA3 outlier filter was originally written for small spaces and the "normal" mode, when running the Loco system in TDoA3 Long Range mode in a large system, it is not doing a great job resulting in outliers getting through. It is probably a good idea to look at the implementation and see if it can be improved, for instance also using the direction to the sample and not only the distance. The outlier filter should be re-written but it will be easier to do after the kalman estimator has been added to the python bindings (#602).


A temporary workaround that seems to solve some of the problem in a large system is to change the settings to

#define MAX_BUCKET_FILL 7
#define FILTER_CLOSE_DELAY_COUNT 20

Adding a maximum error distance that can be set from the ground when the filter has converged is also an option.
Conceptually something like the following code could be inserted here

  if (errorDistance > maxFilterDistance) {
    sampleIsGood = false;
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants