Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning of CPX protocol #1046

Closed
evoggy opened this issue May 10, 2022 · 2 comments · Fixed by #1253
Closed

Versioning of CPX protocol #1046

evoggy opened this issue May 10, 2022 · 2 comments · Fixed by #1253

Comments

@evoggy
Copy link
Member

evoggy commented May 10, 2022

Currently there's no version on the CPX protocol and this should be added. The suggestion is to take 2 of the MSB from the function field, which would then become 6 bits. Since with the current implementation the 2 MSB are already 0 we can decide that the first version of the protocol is 0 and the implementation will not be effected. It's just the definition of the package that will change.

This versioning is not something we need to enforce yet, we can wait until we have a next version.

@knmcguire
Copy link
Contributor

We need to start enforcing this before the next release. The version should be printed out and an assert should happen when a cpx version message comes in that is not the right version.

I'll make issues in https://github.com/bitcraze/aideck-gap8-examples, https://github.com/bitcraze/aideck-esp-firmware, and https://github.com/bitcraze/crazyflie-lib-python

@knmcguire
Copy link
Contributor

Moreover, we should document the version as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants