Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting or inserting characters produce valid strings #34

Closed
ccorcoveanu opened this issue Apr 7, 2020 · 3 comments · Fixed by #40
Closed

Deleting or inserting characters produce valid strings #34

ccorcoveanu opened this issue Apr 7, 2020 · 3 comments · Fixed by #40

Comments

@ccorcoveanu
Copy link

Regarding the recently documented issue where you basically can insert (or remove in some cases) q characters into a bech32 string and produce another valid bech32 string, are you guys planning on introducing the changes proposed Pieter Wuille?
The changes are really small and I would be more than happy to open a PR for this.

Background:
sipa/bech32#51
https://gist.github.com/sipa/a9845b37c1b298a7301c33a04090b2eb
@junderw
Copy link
Member

junderw commented Apr 10, 2020

Pull Requests are welcome.

Personally I would like to wait until the fixes are nailed down in a BIP. But I will definitely review the PR while we wait.

@ccorcoveanu
Copy link
Author

Cool, I will open the PR this week, thanks! :)

@junderw
Copy link
Member

junderw commented Feb 14, 2021

Fixed in #40

@junderw junderw linked a pull request Feb 14, 2021 that will close this issue
Add BIP350 Bech32m support #40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BIP350 Bech32m support andrewtoth/bech32
2 participants
@junderw @ccorcoveanu