Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill TransactionDetails #922

Closed
Tracked by #918 ...
notmandatory opened this issue Mar 22, 2023 · 2 comments · Fixed by #1048
Closed
Tracked by #918 ...

Kill TransactionDetails #922

notmandatory opened this issue Mar 22, 2023 · 2 comments · Fixed by #1048
Labels
discussion There's still a discussion ongoing
Milestone

Comments

@notmandatory
Copy link
Member

Kill TransactionDetails, get details of txs via methods from Wallet instead. Ensure rich data we have from bdk_chain can be observed from Wallet.

@evanlinjin
Copy link
Member

This will most likely conflict with the work done for #895, please only start after PR #926 is complete!

@notmandatory notmandatory added this to BDK May 4, 2023
@notmandatory notmandatory removed this from BDK May 4, 2023
@notmandatory notmandatory added this to BDK May 4, 2023
@notmandatory notmandatory added the discussion There's still a discussion ongoing label May 23, 2023
@LLFourn
Copy link
Contributor

LLFourn commented Jul 27, 2023

Two places left where TransactionDetails is being used:

  1. get_tx should just return a Option<&Transaction> or potentially a TxNode from TxGraph.
  2. as a return value from creating a transaction.

removing (1) is higher priority. You could even keep something like it for (2) so you can return the fee/feerate etc. Changing what gets returned here depends on what happens with transaction building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion There's still a discussion ongoing
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants