Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxOdering::Shuffle is not shuffling the inputs #865

Closed
Tracked by #46
, #918
...
LLFourn opened this issue Feb 14, 2023 · 3 comments
Closed
Tracked by #46
, #918
...

TxOdering::Shuffle is not shuffling the inputs #865

LLFourn opened this issue Feb 14, 2023 · 3 comments
Assignees
@notmandatory
Labels
bug Something isn't working module-wallet

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Feb 14, 2023

TxOdering::Shuffle is not shuffling the inputs (only the outputs).

Bug found while doing bdk core integration. I think it's moderately serious so I think this fix should be backported.
@LLFourn LLFourn added the bug Something isn't working label Feb 14, 2023
@notmandatory notmandatory moved this to Todo in BDK Maintenance Feb 27, 2023
@notmandatory notmandatory mentioned this issue Feb 27, 2023
Closed
21 tasks
@nassersaazi
Copy link

nassersaazi commented Feb 28, 2023 •
edited
Loading

i would love to work on this! it would be my first time contributing to the project, so some context around the issue is highly appreciated

@notmandatory notmandatory mentioned this issue Feb 28, 2023
Closed
6 tasks
@notmandatory
Copy link
Member

Hi @nassersaazi thanks! but I didn't see your note and I just created #876 . Please feel free to review that PR, but it's very simple, the only interesting thing is to see if you can think of any other test cases or any reason why the tx inputs shouldn't be shuffled when we shuffle the outputs.

@notmandatory notmandatory self-assigned this Mar 2, 2023
@notmandatory notmandatory removed this from the Release 0.27.2 Feature Freeze milestone Mar 3, 2023
@notmandatory notmandatory mentioned this issue Mar 23, 2023
Closed
4 tasks
@notmandatory notmandatory added this to BDK May 4, 2023
@notmandatory notmandatory moved this to Todo in BDK Jan 2, 2024
@notmandatory
Copy link
Member

Fixed by @LLFourn with 5985706

@github-project-automation github-project-automation bot moved this from Todo to Done in BDK Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notmandatory notmandatory

Labels
bug Something isn't working module-wallet
Projects
BDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TxOrdering::Shuffle to also shuffle the inputs notmandatory/bdk
3 participants
@LLFourn @notmandatory @nassersaazi