Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TxGraph::map_anchor method #1096

Closed
Tracked by #76
evanlinjin opened this issue Aug 26, 2023 · 2 comments
Closed
Tracked by #76

Implement TxGraph::map_anchor method #1096

evanlinjin opened this issue Aug 26, 2023 · 2 comments
Labels
good first issue Good for newcomers new feature New feature or request
Milestone

Comments

@evanlinjin
Copy link
Member

          Not part of this PR necessarily but the code below seems super complicated and uses changesets for no reason? How about we just have a function on `tx_graph.map_anchor(|anchor| get_new_anchor(anchor))` which consumes self and returns a new `TxGraph` with the new anchor.

Originally posted by @LLFourn in #1084 (comment)

@evanlinjin evanlinjin added good first issue Good for newcomers new feature New feature or request labels Oct 12, 2023
@notmandatory notmandatory added this to BDK Nov 13, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.4 milestone Nov 13, 2023
@notmandatory
Copy link
Member

Does this still need to be done? @LLFourn @evanlinjin

For now I've put it in the alpha.4 milestone so we don't forget to address it.

@LLFourn
Copy link
Contributor

LLFourn commented Nov 16, 2023

The code I was complaining about seems to be a bit improved. I think it still might be a nice method to have but we can close this until the need arises.

@LLFourn LLFourn closed this as completed Nov 16, 2023
@github-project-automation github-project-automation bot moved this to Done in BDK Nov 16, 2023
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@notmandatory notmandatory modified the milestones: 1.0.0, 1.0.0-alpha.3 Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants