Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for electrum, esplora, bitcoind_rpc crates #1094

Closed
Tracked by #74 ...
notmandatory opened this issue Aug 24, 2023 · 4 comments
Closed
Tracked by #74 ...

Add integration tests for electrum, esplora, bitcoind_rpc crates #1094

notmandatory opened this issue Aug 24, 2023 · 4 comments
Labels
Milestone

Comments

@notmandatory
Copy link
Member

notmandatory commented Aug 24, 2023

Describe the enhancement

Basic blockchain integration tests need to be added to confirm scan and sync in different scenarios.

Use case

Example scan and sync test scenarios:

  • single xkey or single key descriptors
  • multisig xkey or single key descriptors
  • multisig with mix of xkey and single key descriptors
  • chain reorg
  • synchronous or async

Additional context

Originally suggested by @danielabrozzoni on discord: https://discord.com/channels/753336465005608961/753367451319926827/1144280548802572319

@notmandatory
Copy link
Member Author

To reduce duplicate code this should be done after #1113, with similar consolidated TestEnv for electrum and bitcoind_rpc crates.

@danielabrozzoni
Copy link
Member

One of my biggest doubt for this is how to test examples. Running cargo test automatically checks that examples build, but we also need to test that they work correctly (otherwise we might have problems such as #1125 or #1151).

We might decide to duplicate the examples code into our tests, but then we need to make sure that the two stay up to date one with the other.

@nondiremanuel
Copy link

According to our previous discussion, for the moment I assign the beta release to both this and the #1113 issue and then if we can make it in time for alpha.3 they can be included

@notmandatory
Copy link
Member Author

Blockchain crates have good test coverage, see #906. We should open new issues for specific scenarios that need more testing.

@github-project-automation github-project-automation bot moved this from Todo to Done in BDK Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants