Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BDK to be built with env_logger version 0.10 #1067

Closed
Tracked by #72
evanlinjin opened this issue Aug 8, 2023 · 2 comments
Closed
Tracked by #72

Allow BDK to be built with env_logger version 0.10 #1067

evanlinjin opened this issue Aug 8, 2023 · 2 comments
Labels
new feature New feature or request

Comments

@evanlinjin
Copy link
Member

Describe the enhancement

As noted by @monaka in #1012, env_logger versions below 0.10 uses atty (which is unmaintained). BDK should allow projects with higher MSRVs to use env_logger.

@apoelstra suggested in #1012 (comment):

If the dep can really be bumped with no changes to the codebase, it may be possible to provide a ranged version that covers multiple major versions.

If this is even possible, we need to update CI to test for every version of env_logger in our specified range using cargo update --precise.

@evanlinjin evanlinjin added the new feature New feature or request label Aug 8, 2023
@notmandatory notmandatory added this to BDK Aug 8, 2023
@notmandatory notmandatory moved this to Todo in BDK Aug 8, 2023
@LLFourn
Copy link
Contributor

LLFourn commented Aug 8, 2023

If this is even possible, we need to update CI to test for every version of env_logger in our specified range using cargo update --precise.

what? 🤣 🤣 Do we rely on the precise details of env_logger to communicate transactions surreptitiously between threads or something? How could env_logger even influence the outcome of a CI?

@LLFourn
Copy link
Contributor

LLFourn commented Aug 8, 2023

We can also just delete env_logger as a dev dependency. It's only used in examples in that we will delete before 1.0 (I hope anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants