Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop treating ECDH as experimental #809

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Stop treating ECDH as experimental #809

merged 2 commits into from
Oct 21, 2020

Conversation

jonasnick
Copy link
Contributor

Fixes #665

@sipa
Copy link
Contributor

sipa commented Sep 9, 2020

ACK, I think it's well tested and the API is sufficiently generic that I don't expect it needing changes any time soon.

@elichai
Copy link
Contributor

elichai commented Sep 9, 2020

Nice, ACK.
so after this only ARM assembly is experimental here?

@real-or-random
Copy link
Contributor

ACK 5a81a2a

@jonasnick
Copy link
Contributor Author

rebased

@jonasnick
Copy link
Contributor Author

so after this only ARM assembly is experimental here?

and schnorrsig :)

elichai
elichai reviewed Sep 12, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@elichai
Copy link
Contributor

elichai commented Sep 12, 2020

ACK 14392d6

real-or-random
real-or-random approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 14392d6 code review, did not test

@sipa sipa mentioned this pull request Sep 16, 2020
Open
@sipa
Copy link
Contributor

sipa commented Oct 20, 2020

utACK 14392d6, but needs rebase

@jonasnick
Copy link
Contributor Author

rebased

real-or-random
real-or-random approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e6e3d5d

elichai
elichai approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@elichai elichai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e6e3d5d

@real-or-random real-or-random merged commit ac05f61 into bitcoin-core:master Oct 21, 2020
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 22, 2020
@jonasnick @Fabcien
[SECP256K1] Stop treating ECDH as experimental
e00ef91 
Summary:
Backport of secp256k1 [[bitcoin-core/secp256k1#809 | PR809]].

Depends on D8044.

Test Plan:
  ./autogen.sh
  mkdir build && cd build
  ../configure --enable-module-ecdh=yes
  make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8049
deadalnix pushed a commit to Bitcoin-ABC/secp256k1 that referenced this pull request Oct 23, 2020
@jonasnick @Fabcien
[SECP256K1] Stop treating ECDH as experimental
2cebbc3 
Summary:
Backport of secp256k1 [[bitcoin-core/secp256k1#809 | PR809]].

Depends on D8044.

Test Plan:
  ./autogen.sh
  mkdir build && cd build
  ../configure --enable-module-ecdh=yes
  make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8049
@AdamISZ AdamISZ mentioned this pull request Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elichai elichai elichai approved these changes

@real-or-random real-or-random real-or-random approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review if ECDH is still experimental
4 participants
@jonasnick @sipa @elichai @real-or-random