-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrivateKey parameters and RFC 5915 #493
Comments
Pull requests welcome. That function is only provided for backward compatibility with systems that need to interact with OpenSSL, though, and the implementation matches what OpenSSL does (as far as I know). |
Its not just OpenSSL. I need to store the key in PKCS #8 for exchange with other system. As for OpenSSL, it now complies with RFC 5915
|
@richardschneider What sipa was pointing out is that encoder inside our contrib directory is not a first class part of the library. We would rather not have that functionality at all and encourage people to not use it-- but we include it (in contrib/) for sake of compatibility with OpenSSL because we needed it for that. If someone wants to submit PRs to make it better, that aren't incompatible with our usage in bitcoin, and aren't too hard to review-- we'll gladly and thankfully take them. But otherwise we are not very interested in supporting DER private key encoding. |
The
PrivateKey.parameters
produced byec_privkey_export_der
currently contain the curve parameters. According to RFC 5915 section 3, it should contain the curve name (OID).Is it possible to change this method, or add a
ec_privkey.export_RFC5480
Expected
Actual
This was first raised in cryptocoinjs/secp256k1-node#123
The text was updated successfully, but these errors were encountered: