Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Peertableview alternating row colors" #306

Closed

Conversation

rebroad
Copy link
Contributor

@rebroad rebroad commented May 1, 2021

Reverts #298

I think this has made the table more cluttered now, and perhaps this pull request could be re-merged in the future once it's done with making the changes optional.

@jonatack
Copy link
Member

jonatack commented May 1, 2021

I agree.

@hebasto
Copy link
Member

hebasto commented May 1, 2021

... making the changes optional.

Done in #307.

@jarolrod
Copy link
Member

jarolrod commented May 3, 2021

My preference would be for #307. Some people were for this change, some against. #307 is the democratic option for appeasing both sides.

@hebasto hebasto added the UI All about "look and feel" label May 9, 2021
@Rspigler
Copy link
Contributor

I am concept NACK this, without a plan for 307, which has now been closed

@rebroad
Copy link
Contributor Author

rebroad commented Jun 26, 2021

I actually quite like the stripes now :) acquired taste I guess....!

@rebroad rebroad closed this Jun 26, 2021
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UI All about "look and feel"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants