Do not use QClipboard::Selection on Windows and macOS. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows and macOS do not support the global mouse selection.
promag
reviewed
Apr 10, 2021
jarolrod
reviewed
Apr 11, 2021
There was a problem hiding this comment.
ACK 7f3a598
EDIT: This still shows up on > Qt 5.9.8 when running with -debug=qt. Tested that this PR fixes the issue on macOS 11.2.3
But I cannot replicate the issue described in #258 when compiling master with Qt 5.15.2 or building master with depends which uses Qt 5.12.10
I can replicate the issue when building the 0.21 tag with depends (Qt 5.9.8). I think the issue linked is not a problem anymore going forward
|
@streamofstars Does this work for you? |
|
Is this for backport to 0.21? |
Yes, I guess. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 17, 2021
…ws and macOS. 7f3a598 qt: Do not use QClipboard::Selection on Windows and macOS. (Hennadii Stepanov) Pull request description: Windows and macOS do [not support](https://doc.qt.io/qt-5/qclipboard.html#notes-for-windows-and-macos-users) the global mouse selection. Fixes #258. ACKs for top commit: promag: Code review ACK 7f3a598. jarolrod: ACK 7f3a598 Tree-SHA512: be2beeef7d25af6f4d4a4548325d8d29f08e4342f499666bc4a670ed468a63195d514077c2cd0dba197e12bd43316fd3e2813cdc0954364b6aa4ae6b90c118bf
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 11, 2021
Windows and macOS do not support the global mouse selection. Github-Pull: bitcoin-core/gui#277 Rebased-From: 7f3a598
|
Backported in bitcoin/bitcoin#22427. |
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Jul 29, 2021
e3f1da4 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov) 6ca54ce qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov) f220368 qt: Do not use QClipboard::Selection on Windows and macOS. (Hennadii Stepanov) Pull request description: Backports bitcoin-core/gui#277, bitcoin-core/gui#365. ACKs for top commit: fanquake: ACK e3f1da4 jarolrod: ACK e3f1da4 Tree-SHA512: 43cc2ac48f4e5014bfdbe86cc904bb36d2be9fcd257f0fc0800c384bd727bb98466723e450a8909b06708784ad91184be599c49cf60de2e4377202774cb878f6
ComputerCraftr
pushed a commit
to ComputerCraftr/XEP-Core
that referenced
this pull request
Aug 18, 2021
e3f1da4bf3db120cc691a844d612fbc522f11fb9 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov) 6ca54ce2ae0808513172c4945e38165e766e1381 qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov) f220368220abb11040fa944a853cda3d4f1fe84d qt: Do not use QClipboard::Selection on Windows and macOS. (Hennadii Stepanov) Pull request description: Backports bitcoin-core/gui#277, bitcoin-core/gui#365. ACKs for top commit: fanquake: ACK e3f1da4bf3db120cc691a844d612fbc522f11fb9 jarolrod: ACK e3f1da4bf3db120cc691a844d612fbc522f11fb9 Tree-SHA512: 43cc2ac48f4e5014bfdbe86cc904bb36d2be9fcd257f0fc0800c384bd727bb98466723e450a8909b06708784ad91184be599c49cf60de2e4377202774cb878f6
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows and macOS do not support the global mouse selection.
Fixes #258.