User Agent header flickers when trying to resize any column

[hebasto]

System: Linux Mint 20.1 + Cinnamon DE + Qt 5.12.8

[jarolrod]

Confirming the same happens on macOS 11.1 + Qt 5.15.2

[RandyMcMillan]

Appending a "bumper" as the last column of the peertablemodel should fix this issue.

In this stale PR - I found that was a reasonable solution.

https://github.com/bitcoin-core/gui/pull/135/files#diff-e721b02fefce2a90ae95da0841adfdcc610ffccf93236ef236f81c1baead8e01R112

[hebasto]

Appending a "bumper" as the last column of the peertablemodel should fix this issue.

In this stale PR - I found that was a reasonable solution.

https://github.com/bitcoin-core/gui/pull/135/files#diff-e721b02fefce2a90ae95da0841adfdcc610ffccf93236ef236f81c1baead8e01R112

@RandyMcMillan
Could that change be separated from #135 into its own bugfix PR?

[RandyMcMillan]

I will take a look - the PR may be too stale.

[RandyMcMillan]

I should have a fix in a few minutes.

[hebasto]

@RandyMcMillan
Another option is to fix the TableViewLastColumnResizingFixer class.

EDIT: it seems TableViewLastColumnResizingFixer is not used here...

[hebasto]

Interesting that the banlistWidget has the same properties as the peerWidget, but the former works without flickering.

[hebasto]

It appears that this bug is fixed in f73d340 (#164).

@jarolrod Could you check it please?

[jarolrod]

@hebasto testing now

One note about this bug is that it happens if that User Agent column is a certain size. If I resize the User Agent column to be smaller, then it doesn't happen when I got to resize other columns. But, if I bring it back to its original size, the bug shows up.

[jarolrod]

@hebasto confirming that #164 fixes this bug, seems that your refactoring of PeerTableModel::refresh() did the job