Detail view shows disconnected peer's info

[hebasto]

To reproduce

1. select the "Peer" tab in the "Node window"

2. choose any peer by clicking its row in the table, the detail view shows the peers's info

3. wait until the chosen peer disconnect

Expected behavior

The detail view stops showing the disconnected peer's info (probably, show nothing).

Actual behavior

The detail view is still showing the disconnected peer's info that is wrong.

System information

Bitcoin Core 0.21.0rc3

Linux Mint 20

[hebasto]

cc @promag

[maflcko]

Is this a regression?

[hebasto]

Hmm, cannot reproduce this issue on regtest connecting some nodes each to other.

[hebasto]

Ok, I've managed to reproduce it:

Steps to reproduce: use column sorting in peer table, and then let a peer to disconnect.

[hebasto]

@MarcoFalke

Is this a regression?

No, it isn't. The 0.20.0 has the same behavior.

[hebasto]

Not observed on master(f4ac48d) due to the #13. But peer table logic is still broken if the table is sorted, see #18.

Closing.