Update reference to macOS SDK extraction instructions #68
Conversation
|
ACK 1381c21 |
|
Should https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/extract-osx-sdk.sh be deleted as well? |
Correct. But it is in another repo :) |
|
On a second thought, should the previous instructions (or a link to them) be preserved, because they are still needed for gitian builds of old tags? |
Is it enough for a reader to just switch the branch: for example https://github.com/bitcoin/bitcoin/blob/0.20/contrib/macdeploy/README.md ? |
gitian-building.md
Outdated
| macOS code signing | ||
| ------------------ | ||
| In order to sign builds for macOS, you need to download the free SDK and extract a file. | ||
| The steps are described [here](https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction). |
There was a problem hiding this comment.
| The steps are described [here](https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction). | |
| The steps are described [here](https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction) for `Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers.tar.gz`. | |
| The steps are described [here](https://github.com/bitcoin-core/docs/blob/a706cc6afde0c8999fb0b8e3356522a7f8e2ad8f/gitian-building/gitian-building-mac-os-sdk.md) for `MacOSX10.11.sdk.tar.gz`. |
There was a problem hiding this comment.
Updated.
But a new list of the explicitly mentioned extracted SDKs misses MacOSX10.14.sdk.tar.gz.
This change allows to remove outdated extract-osx-sdk.sh from the master branch in the main repository.
|
ACK 0aebb72 |
1fbb8b6 script: Remove outdated extract-osx-sdk.sh (Hennadii Stepanov) Pull request description: The removed script was used to prepare `MacOSX10.11.sdk` which we do not use since 0.20 (bitcoin/bitcoin@7e21044 from #16392). See bitcoin-core/docs#68. ACKs for top commit: laanwj: ACK 1fbb8b6 Tree-SHA512: ab5128ec2c505a43b1a12e06abf38d8fa8f62a03efe760de2c842550e82f68ca512dee1b6c220a4f8af2465a9c35a429ca91cb179cc4ce016fcd87c61fbc8b07
1fbb8b6 script: Remove outdated extract-osx-sdk.sh (Hennadii Stepanov) Pull request description: The removed script was used to prepare `MacOSX10.11.sdk` which we do not use since 0.20 (bitcoin@7e21044 from bitcoin#16392). See bitcoin-core/docs#68. ACKs for top commit: laanwj: ACK 1fbb8b6 Tree-SHA512: ab5128ec2c505a43b1a12e06abf38d8fa8f62a03efe760de2c842550e82f68ca512dee1b6c220a4f8af2465a9c35a429ca91cb179cc4ce016fcd87c61fbc8b07
This PR replaces the outdated
gitian-building/gitian-building-mac-os-sdk.mdwith the link to https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/README.md#sdk-extraction