Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Update gitian-building.md #66

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Update gitian-building.md #66

merged 1 commit into from
Dec 2, 2020

Conversation

miketwenty1
Copy link
Contributor

fixing typo

hebasto
hebasto suggested changes Nov 29, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK 93dc9ff.

Also I'd suggest to use long versions of arguments in documentation, i.e.:

  • s/-b/--build/
  • s/-s/--sign/

gitian-building.md Outdated Show resolved Hide resolved
@hebasto
Copy link
Member

hebasto commented Nov 30, 2020

LGTM, mind squashing two commits into single one?

@miketwenty1 @hebasto
Update gitian-building.md
aafd085 
fixing typo

Update gitian-building.md

Co-authored-by: Hennadii Stepanov <[email protected]>
@miketwenty1
Copy link
Contributor Author

@hebasto np, done.

@jonasschnelli
Copy link

Verified (https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-build.py#L171).
utACK aafd085

hebasto
hebasto approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aafd085, I have reviewed the code and it looks OK, I agree it can be merged.

@maflcko maflcko merged commit a706cc6 into bitcoin-core:master Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miketwenty1 @hebasto @jonasschnelli @maflcko