Edit 0.14.1 release notes to separate multiple PRs with "," instead of "/" #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested:
|
|
Code review ACK 98b565a
Good catch. A good thing that separating with |
laanwj
added a commit
that referenced
this pull request
Jan 15, 2021
2ca4ef2 Plugins: fix monotree repo ref from gui/#123 to gui#123 (David A. Harding) Pull request description: There was a slight miscommunication about the expected format in #733, this uses the format from #734 as tested on the actual release notes:  I also quickly checked the HTML diff from before and after this change and I only saw one unwanted change (a link to an issue was dropped). I think that's acceptable to keep the pattern simple.  ACKs for top commit: laanwj: ACK 2ca4ef2 Tree-SHA512: 4e312ac92904f0abab70ca0fa5d45586bff686746162d25ae9ce0653f732e9e0964ea435a9a0f7a4fa40de4ee4372a7cb9c37f8e53a55d978333636bf89373fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned today in #bitcoin-core-dev IRC, the release notes for 0.21.0 will include at least one reference to a PR that was merged in the new GUI repository. laanwj said he'll put this in the notes as "gui/#nnnn", so this PR updates the plugin to handle that appropriately.
To eliminate conflicts, one historic release note is updated to change from using
/as a separator between PRs to using,as the separator. The comma is consistent with other release notes, such as that for 0.14.0.This change should be forward compatible for other possible monotree repos as long as they're part of the bitcoin-core organization and the release notes use the format
<repo-name>/#<pr-number>, e.g.wallet/#123.