From 52abd8e2e2a7061713a0380a33d9b315d73d08d8 Mon Sep 17 00:00:00 2001
From: Daniel Nelson <daniel.nelson@influxdb.com>
Date: Mon, 26 Aug 2019 16:05:56 -0700
Subject: [PATCH] Add support for parked process state on Linux (#6308)

---
 plugins/inputs/processes/README.md         |  1 +
 plugins/inputs/processes/processes.go      |  5 +++
 plugins/inputs/processes/processes_test.go | 52 ++++++++++++++++++++++
 3 files changed, 58 insertions(+)

diff --git a/plugins/inputs/processes/README.md b/plugins/inputs/processes/README.md
index 3c2e27291be98..4113f0d3af1f7 100644
--- a/plugins/inputs/processes/README.md
+++ b/plugins/inputs/processes/README.md
@@ -32,6 +32,7 @@ Using the environment variable `HOST_PROC` the plugin will retrieve process info
     - wait (freebsd only)
     - idle (bsd and Linux 4+ only)
     - paging (linux only)
+    - parked (linux only)
     - total_threads (linux only)
 
 ### Process State Mappings
diff --git a/plugins/inputs/processes/processes.go b/plugins/inputs/processes/processes.go
index c71d72f505e85..379a9cb377929 100644
--- a/plugins/inputs/processes/processes.go
+++ b/plugins/inputs/processes/processes.go
@@ -178,6 +178,11 @@ func (p *Processes) gatherFromProc(fields map[string]interface{}) error {
 			fields["paging"] = fields["paging"].(int64) + int64(1)
 		case 'I':
 			fields["idle"] = fields["idle"].(int64) + int64(1)
+		case 'P':
+			if _, ok := fields["parked"]; ok {
+				fields["parked"] = fields["parked"].(int64) + int64(1)
+			}
+			fields["parked"] = int64(1)
 		default:
 			log.Printf("I! processes: Unknown state [ %s ] in file %s",
 				string(stats[0][0]), filename)
diff --git a/plugins/inputs/processes/processes_test.go b/plugins/inputs/processes/processes_test.go
index 27fdf76a17858..f9bad4b6087bb 100644
--- a/plugins/inputs/processes/processes_test.go
+++ b/plugins/inputs/processes/processes_test.go
@@ -6,7 +6,9 @@ import (
 	"fmt"
 	"runtime"
 	"testing"
+	"time"
 
+	"github.com/influxdata/telegraf"
 	"github.com/influxdata/telegraf/testutil"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -107,6 +109,56 @@ func TestFromProcFilesWithSpaceInCmd(t *testing.T) {
 	acc.AssertContainsTaggedFields(t, "processes", fields, map[string]string{})
 }
 
+// Based on `man 5 proc`, parked processes an be found in a
+// limited range of Linux versions:
+//
+// >    P  Parked (Linux 3.9 to 3.13 only)
+//
+// However, we have had reports of this process state on Ubuntu
+// Bionic w/ Linux 4.15 (#6270)
+func TestParkedProcess(t *testing.T) {
+	procstat := `88 (watchdog/13) P 2 0 0 0 -1 69238848 0 0 0 0 0 0 0 0 20 0 1 0 20 0 0 18446744073709551615 0 0 0 0 0 0 0 2147483647 0 1 0 0 17 0 0 0 0 0 0 0 0 0 0 0 0 0 0
+`
+	plugin := &Processes{
+		readProcFile: func(string) ([]byte, error) {
+			return []byte(procstat), nil
+		},
+		forceProc: true,
+	}
+
+	var acc testutil.Accumulator
+	err := plugin.Gather(&acc)
+	require.NoError(t, err)
+
+	expected := []telegraf.Metric{
+		testutil.MustMetric(
+			"processes",
+			map[string]string{},
+			map[string]interface{}{
+				"blocked":  0,
+				"dead":     0,
+				"idle":     0,
+				"paging":   0,
+				"parked":   1,
+				"running":  0,
+				"sleeping": 0,
+				"stopped":  0,
+				"unknown":  0,
+				"zombies":  0,
+			},
+			time.Unix(0, 0),
+			telegraf.Untyped,
+		),
+	}
+	actual := acc.GetTelegrafMetrics()
+	for _, a := range actual {
+		a.RemoveField("total")
+		a.RemoveField("total_threads")
+	}
+	testutil.RequireMetricsEqual(t, expected, actual,
+		testutil.IgnoreTime())
+}
+
 func testExecPS() ([]byte, error) {
 	return []byte(testPSOut), nil
 }