Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL verification turned off by default #92

Open
LarsFronius opened this issue Nov 7, 2018 · 0 comments
Open

SSL verification turned off by default #92

LarsFronius opened this issue Nov 7, 2018 · 0 comments

Comments

@LarsFronius
Copy link

LarsFronius commented Nov 7, 2018

By the looks of it ( https://github.com/bitbucket-rest-api/bitbucket/blob/master/lib/bitbucket_rest_api/connection.rb#L32 ), by default SSL verification is turned off in the gem.
This is greatly discouraged practice ( see Solutions To Avoid https://github.com/lostisland/faraday/wiki/Setting-up-SSL-certificates ), as we now have the same guarantees about validity of our peer as if we were to use an HTTP connection.

I'd encourage for this gem to turn SSL verification on to guarantee peer validation in the default scenario and thus for it to be a secure default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant