Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bitcoin Core-style ACK / NACK / Nit language in pull request reviews #6

Open
cbeams opened this issue Mar 20, 2018 · 0 comments
Open

Comments

@cbeams
Copy link
Contributor

cbeams commented Mar 20, 2018

From https://bitcoincore.org/en/faq/contributing-code/#peer-review:

Anyone may participate in peer review which is expressed by comments in the pull request. Typically reviewers will review the code for obvious errors, as well as test out the patch set and opine on the technical merits of the patch. Project maintainers take into account the peer review when determining if there is consensus to merge a pull request (remember that discussions may have been spread out over github, mailing list and IRC discussions). The following language is used within pull-request comments:

  • ACK means “I have tested the code and I agree it should be merged”;
  • NACK means “I disagree this should be merged”, and must be accompanied by sound technical justification. NACKs without accompanying reasoning may be disregarded;
  • utACK means “I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged”;
  • Concept ACK means “I agree in the general principle of this pull request”;
  • Nit refers to trivial, often non-blocking issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant