Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 28 #904

Closed
ripcurlx opened this issue Aug 23, 2021 · 7 comments
Closed

For Cycle 28 #904

ripcurlx opened this issue Aug 23, 2021 · 7 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Aug 23, 2021

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 5052
  • USD requested: 7680
  • BSQ rate: 1.52 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 26 #882

As I missed the deadline for Cycle 27 this will be a compound compensation request for Cycle 27 and Cycle 28.
Cycle 27: Because of vacation I wasn't very active in this cycle.

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Bisq Desktop Maintainer (Cycle 27) dev* 2160 bisq-network/roles#63 (comment)
Bisq Desktop Maintainer (Cycle 28) dev* 3060 bisq-network/roles#63 (comment)
Bitcoin Fullnode Operator (Cycle 27) ops* 50 bisq-network/roles#67 (comment)
Bitcoin Fullnode Operator (Cycle 28) ops* 50 bisq-network/roles#67 (comment)
GitHub Admin (Cycle 27 ops* 25 bisq-network/roles#16 (comment)
GitHub Admin (Cycle 28 ops* 25 bisq-network/roles#16 (comment)
Release preparations (Cycle 27) dev* 300 v1.7.2
Release preparations (Cycle 28) dev* 300 v1.7.3
Testing (Cycle 27) dev 180 Test reports for v1.7.2
Testing (Cycle 28) dev 180 Test reports for v1.7.3
PR Review #5672 dev 100 bisq-network/bisq#5672
PR Review #5682 dev 50 bisq-network/bisq#5682
Tor v3 bitcoinj support dev 1200 bisq-network/bisq#5686, https://github.com/bisq-network/bitcoinj This was mainly a review, cherry-picking & resolve conflicts action starting with commit bisq-network/bitcoinj@e7b7bfe until bisq-network/bitcoinj@57ea47f. Additionally I needed to Add deprecated constructors, Add Tor v3 onion address support and minor code clean up and Remove dead code parts, improve documentation and fix broken unit tests. @sqrrm had to review all cherry-picked commits and my new additions to our bitcoinj fork. I tested all changes already for some time on Mainnet (including full trades) without any problems so far 🤞

I'm not putting up my team lead efforts up for compensation (~5% of my time).

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Cycle 27

I'm working on porting the Tor v3 support from bitcoinj into our bitcoinj fork.

Cycle 28

I continued to work on the Tor v3 support and migration process for Bisq. Next I do plan to continue working on the bitcoinj fork by reviewing the changes suggested by @sqrrm to enable atomic BTC<->BSQ transactions.

@MwithM MwithM added this to the Cycle 28 milestone Sep 16, 2021
@ripcurlx ripcurlx changed the title [WIP] For Cycle 28 For Cycle 28 Sep 20, 2021
@ghost
Copy link

ghost commented Sep 20, 2021

Info

Read BSQ amount from summary: 5260
Read USD amount from summary: 7680
Read BSQ rate from summary: 1.46
Parsed lineitem: {"team":"dev","amount":2160}
Parsed lineitem: {"team":"dev","amount":3060}
Parsed lineitem: {"team":"ops","amount":50}
Parsed lineitem: {"team":"ops","amount":50}
Parsed lineitem: {"team":"ops","amount":25}
Parsed lineitem: {"team":"ops","amount":25}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":180}
Parsed lineitem: {"team":"dev","amount":180}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":1200}

Errors

Incorrect BSQ rate specified: 1.46, expected: 1.52
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 5260.00 BSQ
  • Calculated total: 5052.63 BSQ

@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team labels Sep 20, 2021
@ghost
Copy link

ghost commented Sep 20, 2021

Info

Read BSQ amount from summary: 5260
Read USD amount from summary: 7680
Read BSQ rate from summary: 1.46
Parsed lineitem: {"team":"dev","amount":2160}
Parsed lineitem: {"team":"dev","amount":3060}
Parsed lineitem: {"team":"ops","amount":50}
Parsed lineitem: {"team":"ops","amount":50}
Parsed lineitem: {"team":"ops","amount":25}
Parsed lineitem: {"team":"ops","amount":25}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":180}
Parsed lineitem: {"team":"dev","amount":180}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":1200}

Errors

Incorrect BSQ rate specified: 1.46, expected: 1.52
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 5260.00 BSQ
  • Calculated total: 5052.63 BSQ

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Sep 20, 2021
@Emzy
Copy link

Emzy commented Sep 20, 2021

Approved for ops.

@sqrrm
Copy link
Member

sqrrm commented Sep 21, 2021

I approve dev.

@ripcurlx
Copy link
Contributor Author

TXID: a16445e0956e68eb5c897f8321877cc276559d04c69e9f131c3b68e9fb93a183

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Sep 30, 2021
@ghost
Copy link

ghost commented Sep 30, 2021

Issuance by Team:

team amount BSQ amount USD
dev 4953.33 7530.00
ops 98.67 150.00

Total Issuance: 5052.00 BSQ (equivalent to: 7680.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Sep 30, 2021

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants