Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 20 #709

Closed
freimair opened this issue Nov 10, 2020 · 8 comments
Closed

For Cycle 20 #709

freimair opened this issue Nov 10, 2020 · 8 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:failed Indicates that DAO vote failed to complete.
Milestone

Comments

@freimair
Copy link

freimair commented Nov 10, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 3929
  • USD requested: 2750
  • BSQ rate: 0.7 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 20 #708

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Establish network usage metrics dev 2250 bisq-network/projects#13 (comment)
Software part of bisq-network/projects#22 dev 325 bisq-network/bisq#4685 The commits starting with "Added ..." contain the work done for the project and since whatever makes it into master is up for compensation, I ask for compensation
Compile a config package for the monitor dev 175 delivered to @Emzy personally, since it is 150MB of configuration database for the graphana frontend plus 350MB of historical data + other configuration. I leave it to you to decide how 150MB worth of binary configuration data gets included into a repository

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@freimair freimair changed the title [WIP] For Cycle 19 For Cycle 19 Nov 10, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Nov 10, 2020
@MwithM MwithM added this to the Cycle 19 milestone Nov 21, 2020
@chimp1984
Copy link

As I stated in the past request as well I think the request for #25 is too high IMO. I will not support more than about 50% of the old one (3200) which is about 1600 USD. You can split it also in 2 separate compensation requests so the uncontroversial part can get accepted easier.

@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Info

Read BSQ amount from summary: 8582
Read USD amount from summary: 5750
Read BSQ rate from summary: 0.67
Parsed lineitem: {"team":"dev","amount":2250}
Parsed lineitem: {"team":"dev","amount":325}
Parsed lineitem: {"team":"dev","amount":175}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 5750.00 USD
  • Calculated total: 2750.00 USD

@freimair freimair mentioned this issue Dec 3, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Dec 3, 2020
@freimair freimair changed the title For Cycle 19 For Cycle 20 Dec 3, 2020
@MwithM MwithM modified the milestones: Cycle 19, Cycle 20 Dec 9, 2020
@freimair
Copy link
Author

@ripcurlx it seems to me you did not look at the CR in detail. Chimp said to split the CR, and I did just that.

You can split it also in 2 separate compensation requests so the uncontroversial part can get accepted easier.

May I have at least some comment on this CR?

@ripcurlx
Copy link
Contributor

@ripcurlx it seems to me you did not look at the CR in detail. Chimp said to split the CR, and I did just that.

You can split it also in 2 separate compensation requests so the uncontroversial part can get accepted easier.

May I have at least some comment on this CR?

I didn't see that you made any changes as edits are not displayed visible in the timeline of the issue.
I can confirm that https://monitor.bisq.network nearly works as before.
Bildschirmfoto 2020-12-29 um 19 38 31
Do you have an idea why this are not working yet? That would be the most important metric for me.

@freimair
Copy link
Author

freimair commented Dec 30, 2020

I didn't see that you made any changes as edits are not displayed visible in the timeline of the issue.

well now you know

I can confirm that https://monitor.bisq.network nearly works as before.

I have no access to the monitoring infrastructure anymore after Bisq insisted that I hand it over. Emzy confirmed afaik that he received all he needs and I have given all the configuration I had. Am I now denied compensation because others fail to fill in?

Do you have an idea why this are not working yet? That would be the most important metric for me.

A wild guess would be that the markets API cannot be reached (because its API changed or moved to another address) or the seednode query does not deliver the offerbook data. There have been code changes afaik affecting the overall inner workings of the monitor daemon... But as I said, I have no access to anything anymore, I can neither tell you what is wrong nor can I fix it. Sorry.

@freimair
Copy link
Author

freimair commented Jan 1, 2021

Since time is running short and it seems like this CR is not going to get a nACK/ACK in time (again), I file the CR anyways and thereby trust the Bisq community to come to a proper conclusion.

7df83af561c0811789dbbe5fe306e29d4549de4eb340a01026ea8e6fabd2427d

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 1, 2021

I would appreciate that we get the monitor in a state, that the most important KPI does work again. Maybe @Emzy could you directly contact @freimair to figure this out? But besides that open issue IMO as team lead I approve this request.

@MwithM MwithM added the was:failed Indicates that DAO vote failed to complete. label Jan 10, 2021
@MwithM
Copy link
Contributor

MwithM commented Jan 10, 2021

Cycle 20 DAO vote failed. Submit a new DAO request for next cycle.

@MwithM MwithM closed this as completed Jan 10, 2021
This was referenced Jan 21, 2021
@freimair freimair mentioned this issue Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:failed Indicates that DAO vote failed to complete.
Projects
Archived in project
Development

No branches or pull requests

4 participants