forked from bitcoinj/bitcoinj
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase to upstream v0.16.3 #44
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Bisq wallet is built on top BitcoinJ, and BitcoinJ stored the total chainwork in a 12-byte field. Unfortunately, the 12-byte field was exhausted and caused BitcoinJ to fail processing blocks above chain height 849,137. The BitcoinJ developers converted the field to an unsigned 12-byte field as a hotfix 1 and we cherry-pick that change into our fork.
Later the BitcoinJ developers released a proper fix in v0.16.3 2, but our fork is based on v0.15.10. I migrated our fork to v0.16.3 3. We can't use the migrated library yet because Bisq uses removed APIs. I'm working on it.
Footnotes
StoredBlock: use Utils.bigIntegerToBytes to convert chainWork (Backport) ↩
Version 0.16.3 - Release Notes ↩
https://github.com/alvasw/bitcoinj/tree/bisq_0.16.3 ↩
The text was updated successfully, but these errors were encountered: