From d41a790e0eda64773e2defae3b56854567cd2e36 Mon Sep 17 00:00:00 2001 From: axpoems <145597137+axpoems@users.noreply.github.com> Date: Sun, 31 Dec 2023 15:23:47 +0100 Subject: [PATCH] Remove temporary comments --- .../open_trades/trade_state/states/SellerState3a.java | 3 +-- .../bisq_easy/protocol/BisqEasyBuyerAsMakerProtocol.java | 6 ------ .../bisq_easy/protocol/BisqEasyBuyerAsTakerProtocol.java | 9 +-------- 3 files changed, 2 insertions(+), 16 deletions(-) diff --git a/apps/desktop/desktop/src/main/java/bisq/desktop/main/content/bisq_easy/open_trades/trade_state/states/SellerState3a.java b/apps/desktop/desktop/src/main/java/bisq/desktop/main/content/bisq_easy/open_trades/trade_state/states/SellerState3a.java index 2c1e568f88..b27d8799c6 100644 --- a/apps/desktop/desktop/src/main/java/bisq/desktop/main/content/bisq_easy/open_trades/trade_state/states/SellerState3a.java +++ b/apps/desktop/desktop/src/main/java/bisq/desktop/main/content/bisq_easy/open_trades/trade_state/states/SellerState3a.java @@ -88,7 +88,7 @@ private void onBtcSent() { @Getter private static class Model extends BaseState.Model { - @Setter // TODO: why setter here? + @Setter protected String btcAddress; private final StringProperty txId = new SimpleStringProperty(); @@ -107,7 +107,6 @@ public static class View extends BaseState.View { private View(Model model, Controller controller) { super(model, controller); - // TODO: no need for the pair (ie. WrappingText here) Pair confirmPair = FormUtils.getConfirmInfo(); fiatReceiptConfirmed = confirmPair.getFirst(); HBox fiatReceiptConfirmedHBox = confirmPair.getSecond(); diff --git a/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsMakerProtocol.java b/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsMakerProtocol.java index c42ee9ae3b..5f82a9af11 100644 --- a/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsMakerProtocol.java +++ b/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsMakerProtocol.java @@ -58,12 +58,6 @@ public void configTransitions() { addTransition() .from(BUYER_SENT_FIAT_SENT_CONFIRMATION) -// .on(BisqEasySendBtcAddressEvent.class) -// .run(BisqEasySendBtcAddressEventHandler.class) -// .to(BUYER_SENT_BTC_ADDRESS); -// -// addTransition() -// .from(BUYER_SENT_BTC_ADDRESS) .on(BisqEasyConfirmFiatReceiptMessage.class) .run(BisqEasyConfirmFiatReceiptMessageHandler.class) .to(BUYER_RECEIVED_SELLERS_FIAT_RECEIPT_CONFIRMATION); diff --git a/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsTakerProtocol.java b/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsTakerProtocol.java index d7973a7aed..43cc0a0f06 100644 --- a/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsTakerProtocol.java +++ b/trade/src/main/java/bisq/trade/bisq_easy/protocol/BisqEasyBuyerAsTakerProtocol.java @@ -50,7 +50,7 @@ public void configTransitions() { .run(BisqEasySendBtcAddressEventHandler.class) .to(BUYER_SENT_BTC_ADDRESS); - addTransition() // -> Skip showing in UI if already there + addTransition() .from(BUYER_SENT_BTC_ADDRESS) .on(BisqEasyAccountDataMessage.class) .run(BisqEasyAccountDataMessageHandler.class) @@ -64,13 +64,6 @@ public void configTransitions() { addTransition() .from(BUYER_SENT_FIAT_SENT_CONFIRMATION) -// .on(BisqEasySendBtcAddressEvent.class) -// .run(BisqEasySendBtcAddressEventHandler.class) -// .to(BUYER_SENT_BTC_ADDRESS); - - -// addTransition() -// .from(BUYER_SENT_BTC_ADDRESS) .on(BisqEasyConfirmFiatReceiptMessage.class) .run(BisqEasyConfirmFiatReceiptMessageHandler.class) .to(BUYER_RECEIVED_SELLERS_FIAT_RECEIPT_CONFIRMATION);