Hide offers which are over the trade limit #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit. Filter offers at OfferBookViewModel when the DaoState changes. Check for offers amount exceeds trade limit at OpenOfferManager and add it to invalidOffers. Signed-off-by: HenrikJannsen <[email protected]>
…he factor of which the DAO param has changed. Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Fix type Add comment Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
HenrikJannsen
force-pushed
the
hide-offers-which-are-over-the-trade-limit
branch
from
b460b45
to
8c07c11
Compare
They fail when running from terminal but not when running in IDE Signed-off-by: HenrikJannsen <[email protected]>
HenrikJannsen
dismissed
alejandrogarcia83’s stale review
The merge-base changed after approval.
alejandrogarcia83
dismissed
their stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7115