Increase MAX_REPEATED_REQUESTS #7069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d node to 100. In case the other seed node has not updated the historical data is not taken into account, thus we would get more repeated requests until all data is received. To avoid that we get stuck we increase the limit. Signed-off-by: HenrikJannsen <[email protected]>
HenrikJannsen
added a commit
to HenrikJannsen/bisq
that referenced
this pull request
Apr 1, 2024
bisq-network#7069 and bisq-network#7070 as well as more recent resource data Signed-off-by: HenrikJannsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase MAX_REPEATED_REQUESTS from 20 to 30 and in case we are a seed node to 100.
This should mitigate issues when we the last release was long ago and the seed nodes have not updated yet to a new release. The historical data would not be considered in that case and the new node would request all the missing data, which can hit the limit of 20 repeated GetDataRequests. Then if the get data process was never completed we do not load the DaoHashes, thus DAO sync never starts.
The reason to increase for seed nodes more is to ensure that seed nodes would enter a deadlock when one has updated but the others not.
@jmacxx @alvasw : Here is a branch on my repo for seed nodes to temporary update.
https://github.com/HenrikJannsen/bisq/tree/update-to-version-1.9.15-and-add-accountAge-and-tradeStat-resources
This set the version to 1.9.15 and adds the resources but no the DAO data we still don't know if the DAO data are correct.
This branch can be used by seed nodes to update (best to update only 50% initially and test then) so that we can further test the DAO state with the release candidate.
If all OK the release candidate might update the resource files from that branch as it contains more recent data. But not a hard requirement...