Uphold payment method issues to fix

[pazza83]

Description

The Uphold payment method could do with a couple of tweaks to make it a smoother trading experience.

• Add 'Account owner full name' field
• Fix error showing a 4 day trade period to 1 day trade period

When payment is received from an Uphold member an email is received to show the full name of the payee. This is also shown in the app when clicking on the payment details.

There is no way to identify payee from the current field of 'Username or email or phone no'. You can use the payment amount / currency to link payment , but when multiple trades are made this makes it difficult / impossible to achieve. Adding an 'Account owner full name' field would fix this.

The trade screen also shows the payment time as 4 days. This is incorrect. It should be 1 day. See screen shot below:

Version

1.6.4

Steps to reproduce

1. Add Uphold as a payment method. There is no field to add 'Account owner full name'. This should be a required field.
2. Start a trade with Uphold. The UI will show 'Max. trade allowed period' as 4 days. It should be 1 day (the actual remaining time and actual trade window is correct at one day' so I think the 4 day is just a typo.

Expected behaviour

1. Add Uphold as a payment method. User see a field to add 'Account owner full name'. This should be a required field.
2. Start a trade with Uphold. The UI should show 'Max. trade allowed period' as 1 day.

[BtcContributor]

Hi @pazza83, I can handle this issue.

[BtcContributor]

@pazza83 I finished the implementation of this fix.

Now it looks like this:

Unfortunately I was not be able to reproduce in any way the 4 days issue on latest Bisq version (maybe has it been fixed just recently?). I also checked on code and it seems ok to me.
Could you please recheck the issue, please? Otherwise, it seems good to me.

Also, are there any input constraints on the Account owner full name? Length for example, etc.

Once I have this information, I can release a PR.

Thanks!

[pazza83]

Thanks @BtcContributor that is great, very speedy!

I will keep an eye out on trades after the PR.

There are no restrictions on 'Account owner full name' it is based on what is entered when the user completes KYC with Uphold.