-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include deviation from market price in Market section in Bisq #5277
Comments
Hi are there any @bisq-network/bisq-devs able to take this on. Would tie in well with #5192 |
I can work on this. Can you add further screenshots complimenting the ones above. They should show what you |
@wallclockbuilder yes no problems, I will upload next week |
Hi @wallclockbuilder here are the screenshots showing how I would expect it to look: |
Pretty straightforward. |
Hi @wallclockbuilder how are you progressing with this issue? |
Hi @xyzmaker123 let me know if you would like to work on this issue. |
@pazza83 Regarding trades deviation - I'm not sure if it's possible to calculate it. I suppose it should be deviation based on market price in the moment of trade - not based on the current price. Unfortunately I don't think we store somewhere historical prices. |
Hi @xyzmaker123 the deviation is the markup (positive or negative the maker chose if choosing to trade on a percentage basis) |
@pazza83 Yeah - I understand. But let's consider this scenario:
Question: is it possible to know what was average market price in Apr 2, 2021 today? |
Description
The entire section of the Bisq market section (with the exception of the make/take offer screens) does one of the following:
It would be a lot more useful for traders if the all the Bisq market section does the following:
This would make it a lot easier to look at historical trades and see what deviation from market price they were made at (Market > Trades)
I also think by keeping market price as a separate value in Market > Offer Book > Buy / Sell BTC it would make the offers more clear.
Version
v1.5.9
Steps to reproduce
Market > Trades
look at prices what price from market deviation was achieved? You will be unable to tell.Market > Trades
then Download a CSV, look at prices what price from market deviation was achieved? You will be unable to tell.Market > Offer Book > Buy BTC
price from market deviation is included after the trade price (not as clear as it could be)Market > Offer Book > Sell BTC
price from market deviation is included after the trade price (not as clear as it could be)Expected behaviour
Market > Trades
look at prices what price from market deviation was achieved? You will be able to tell and sort by deviation.Market > Trades
then Download a CSV, look at prices what price from market deviation was achieved? You will be able to tell and sort by deviation.Market > Offer Book > Buy BTC
price from market deviation is included in a separate column.Market > Offer Book > Sell BTC
price from market deviation is included in a separate column.Current Screenshots
Deviation from market price info combine with trade price. Not as clear for users.
Missing deviation from market price info.
Example of current CSV file
market price 3 - Copy.txt
Missing deviation from market price info.
The text was updated successfully, but these errors were encountered: