-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static noise while running the app #2867
Comments
In order for the Bisq appli to stay alive on certain machines/OS, the appli plays a sound at the minimum volume. See #1712 |
Sounds can be silent, too. Can we play silent.wav instead of staticnoise.wav? It's really annoying and if linux provides an alternative way, I'd really want that to get reverted. On OSX there is no server feature possible without static noise? Sounds ridiculous to me. |
By the way, silent.aiff is 40MB of high fidelity stereo silence or why is it so big? If actual sound is required, how about 1 minute, mono 12Hz ogg? That would be 23kB. |
for your consideration |
Thanks @gizmo for your inputs. |
@Giszmo You can deactivate it in Settings: Avoid standby mode - has only effect that the sound file is not played. |
@ManfredKarrer What about the file size? 40MB? Seriously? How did that ever get approved? @HarryMacfinned in my experience, even serious bugs get reported by about 1% of the users only. If I wasn't so close with the project, I wouldn't have reported it.
Are you claiming that you do not hear that sound when you put on headphones at moderate volume? The choice of static noise for something meant to be inaudible is weird. White noise by definition contains all frequencies, including those the human is very sensitive to. Using the limits of the audible spectrum of 20-20k Hz, 20Hz or below is the better choice as depending on format and codec, 20kHz might result in lower frequency "noise" again. If 12Hz works for the task, even better as it's less data to encode and less audible than even 20Hz. |
As you can just turn it off in the settings, it didn't bother me enough to open a ticket, but I have to agree with @Giszmo here. The file currently used for standby prevention is a pretty weird choice... it has:
In comparison, a mono 8000 Hz 16-bit WAV with 15 seconds of silence has:
A simple
Edit:
|
I provided a zip file with a silent audio file. playing it in audacity is absolutely silent although the equalizer indicates -55dB. Playing the 40MB audio in audacity is giving me the same noise I get in bisq and the equalizer doesn't show me a reading at all. |
Just tested "Avoid standby mode" with headphones on and can confirm that the noise is definitely very audible. I also noticed that Bisq's application volume is set to 100%. Manually changing it to 1% makes it inaudible. In addition to changing the file, maybe it would be a good idea to make Bisq set its own volume to 1% (or even 0%, if it still prevents the shutdown, then) |
Give back money to Monica, stolen from her using Mycelium wallet! This Alexander Kuzmenko - was in custody for stealing! He steals for same thieves like he is!! Don’t believe or work with Mycelium or Waves platform, it’s same Russian scam ! |
Agree that the noise it definitely audible. A smaller and silent .ogg file sounds like a better choice if someone feels like implementing. The only thing is to make sure it actually prevents sleep mode, I remember @ManfredKarrer mentioned there were some issues with some sound file and hence chose the monster we now have. |
@sqrrm Yes it took me quite a bit of time for testing until it worked reliable. Using a silent sound did not work and also using short sounds had issues (started with that; but don't remember what it was exactly the problem with that approach). Testing it was pretty cumbersome as you need to wait until OS gets to sleep mode and wait a bit until resources get throttled and then wait for timeout. Easiest path would be the reduce the volume if the existing sound and test if it still works. Bitrate could be reduced as well and mono can be used. Maybe using a very low frequency which most headsets don't reproduce might be another option, but needs to be tested if it still does its job. We got definitely less disputes with that fix. At least for OSX users we know it helped. If there is a VM argument for telling the app in Linux to run as server that might be an option if that works reliable for Linux. Then the sound can be only used on OSX and Windows. Testing if it was an issue at all on Linux would be good as well. It was not really tested on Windows. So if someone can do that would be good. Not sure if it was a OSX issue only. But I would recommend to not remove it until its tested that it does not cause failed take-offer attempts if not playing. The problem was that offers still stay online but when a user takes the offer a timeout gets triggered as the makers OS in sleep mode has throttled resources that much that it did not respond in time. The republishing of the offers though still worked. I did not find details information how OSX handled that and it has changed over the past years as it was never observed 2-3 years ago. |
Do not remove the sound unless you are ABSOLUTELY SURE that messages are not lost. Arbitration is simply impossible in such situations. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
Is this not still relevant? I'm seeing it in the current version of the app on Windows. What would need to be tested on Windows, @ManfredKarrer ? You said, " Testing it was pretty cumbersome as you need to wait until OS gets to sleep mode and wait a bit until resources get throttled and then wait for timeout." Is the sound what is theoretically keeping the OS from going to sleep? I can't imagine that Windows would require an audible sound to do this. How would Windows even know what is actually audible? |
Is it to prevent the app being napped in OSX, or the actual OS going to sleep, or both? On Windows, at least, I know there's something called Power Throttling, but I don't know if it would apply to this issue. |
I just realized that having "Loudness equalization" checked under the Windows Sound Control Panel -> Default playback device's properties -> Enhancements tab is what makes this static very audible. I would like to keep this setting checked on my laptop for sound loudness reasons, but, unfortunately it leads to this problem with Bisq. |
A new PR was just merged which reduced the sound level to the absolute minimum. Also reduce file size a lot. |
When starting Bisq, I immediately get static noise on my headphones as soon as the UI becomes visible. On no other app do I get that. What is causing it? It feels almost like comfort noise on voip apps.
The text was updated successfully, but these errors were encountered: