Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HalCash #1619

Merged
merged 5 commits into from
Aug 14, 2018
Merged

Add HalCash #1619

merged 5 commits into from
Aug 14, 2018

Conversation

ManfredKarrer
Copy link
Contributor

@ManfredKarrer ManfredKarrer mentioned this pull request Aug 10, 2018
Closed
@ManfredKarrer
Add adjustment fro multiple ofg 10 EUR for HalCash
3bce2b8 
With ATMs one can withdraw only multiples of 10 EUR.
We adjust the input values the way that the EUR amount leads to
multiple of 10. MinAmount and amount will be adjusted.

Please note that a similar approach like implemented here for HalCash
can be used for removing the decimal places from fiat amounts to
improve privacy. We keep that for a follow up PR to not mix 2 different
use cases.
@ripcurlx
Copy link
Contributor

bildschirmfoto 2018-08-14 um 17 59 36

Editing of HalCash offer doesn't work properly atm. The price is updated, but the amount stays the same.

@ripcurlx
Copy link
Contributor

I just recognized that the min amount is updated. Just looked like an error having a min-max range of 50-50.

@ManfredKarrer
Copy link
Contributor Author

Hm... yes thats not good. I will have a look

ripcurlx
ripcurlx approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested it locally and everything worked except some edge cases when editing an offer. When the edit offer change discussed in Zoom is implemented everything is OK from my side.

@ManfredKarrer ManfredKarrer merged commit 5de04ce into bisq-network:master Aug 14, 2018
@ManfredKarrer ManfredKarrer deleted the halcash branch August 14, 2018 18:54
@ripcurlx ripcurlx mentioned this pull request Aug 30, 2018
Closed
@ManfredKarrer ManfredKarrer mentioned this pull request Aug 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManfredKarrer @ripcurlx