refactor(useArrayLiterals): check all expressions and add a fix #4416
+457
−107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces several fixes/improvements for
useArrayLiterals
:Improve correctness
Previously, the rule reported only use of the
Array
constructor in expressions statements.The rule now correctly report these two cases.
Support
globalThis.Array
andwindow.Array
and don't reportArray
that resolves to a defined variable.Add a code fix.
Improve diagnostics
Test Plan
I added tests and updated snapshots.