feat(lint): add noImgElement rule
#4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
kaioduarte
changed the title
no-img-element from eslint-plugin-next
CodSpeed Performance ReportMerging #4155 will not alter performanceComparing Summary
|
kaioduarte
force-pushed
the
no-img-element
branch
from
45943e1
to
4e10665
Compare
ematipico
requested changes
Oct 6, 2024
Comment on lines
48
to
50
| i Consider using <Image /> from next/image to automatically optimize images. | ||
|
|
||
| i This may incur additional usage or cost from your provider. |
There was a problem hiding this comment.
Please swap the messages. It's usually:
- Error
- Explain the error
- Suggest a fix
It's explained in the rule pillars
kaioduarte
changed the title
no-img-element from eslint-plugin-nextnoImgElement from eslint-plugin-next
kaioduarte
changed the title
noImgElement from eslint-plugin-nextnoImgElement rule
ematipico
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement no-img-element from eslint-plugin-next.
Test Plan
Snapshots + CI