Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 useNamingConvention matcher does not accept \$ #4613

Closed
1 task done
edfenergy-SteveD opened this issue Nov 21, 2024 · 3 comments
Closed
1 task done

🐛 useNamingConvention matcher does not accept \$ #4613

edfenergy-SteveD opened this issue Nov 21, 2024 · 3 comments
Labels
S-Needs triage Status: this issue needs to be triaged

Comments

@edfenergy-SteveD
Copy link

edfenergy-SteveD commented Nov 21, 2024

Environment information

Biome 1.9.4

What happened?

I'm trying to implement a matcher in useNamingConvention to align to an object member that begins with a dollar sign, using the regex \$(.+), however it's not accepting the escaped $.

Can support for this be included in a future build please? We've got a number of api calls that use this format in our project and, at the moment, they're littered with biome-ignores.

Expected result

\$(.+) is an acceptable matcher

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@edfenergy-SteveD edfenergy-SteveD added the S-Needs triage Status: this issue needs to be triaged label Nov 21, 2024
@edfenergy-SteveD edfenergy-SteveD changed the title 🐛 <TITLE> 🐛 useNamingConvention matcher does not accept \$ Nov 21, 2024
@ematipico
Copy link
Member

This doesn't seem a bug but a feature request?

@Conaclos
Copy link
Member

Conaclos commented Nov 21, 2024

I'm trying to implement a matcher in useNamingConvention to align to an object member that begins with a dollar sign, using the regex $(.+), however it's not accepting the escaped $.

I guess it is in the Biome JSON config file? In that case you have to double escape \: \\$(.+). You can also write [$](.+)

@edfenergy-SteveD
Copy link
Author

@Conaclos - oh for goodness' sake, that was it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs triage Status: this issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants