Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 useSemanticElements should ignore inline SVG with role="img" #3828

Closed
1 task done
Conaclos opened this issue Sep 8, 2024 · 0 comments · Fixed by #3837
Closed
1 task done

🐛 useSemanticElements should ignore inline SVG with role="img" #3828

Conaclos opened this issue Sep 8, 2024 · 0 comments · Fixed by #3837
Assignees
@togami2864
Labels
A-Linter Area: linter L-CSS Language: CSS S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Conaclos
Copy link
Member

Conaclos commented Sep 8, 2024

Environment information

Main

What happened?

Inline SVG with the role img is reported by the rule (Playground).
Adding role="img" on an inline SVG is a recommendation from MDN.

Expected result

We should ignore role="img" on SVG elements.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@togami2864 togami2864

Labels
A-Linter Area: linter L-CSS Language: CSS S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter): allow SVG elements with role="img" togami2864/biome
2 participants
@Conaclos @togami2864