Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] emit styles #191

Merged
merged 2 commits into from
Feb 1, 2022
Merged

[wip] emit styles #191

merged 2 commits into from
Feb 1, 2022

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Jan 17, 2022

re #37

@biojppm biojppm marked this pull request as draft January 17, 2022 16:45
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #191 (f702535) into master (bd4f2c1) will decrease coverage by 0.17%.
The diff coverage is 93.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   96.83%   96.65%   -0.18%     
==========================================
  Files          74       75       +1     
  Lines       15355    15806     +451     
==========================================
+ Hits        14869    15278     +409     
- Misses        486      528      +42     
Impacted Files Coverage Δ
test/test_block_literal.cpp 100.00% <ø> (ø)
test/test_case.hpp 46.90% <ø> (ø)
src/c4/yml/emit.def.hpp 88.86% <85.80%> (-7.21%) ⬇️
test/test_emit.cpp 99.14% <99.14%> (ø)
src/c4/yml/emit.hpp 100.00% <100.00%> (ø)
src/c4/yml/node.hpp 97.54% <100.00%> (ø)
src/c4/yml/tree.hpp 98.61% <100.00%> (+0.06%) ⬆️
test/test_case.cpp 87.01% <100.00%> (-0.11%) ⬇️
test/test_null_val.cpp 100.00% <100.00%> (ø)
test/test_suite.cpp 96.47% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4f2c1...f702535. Read the comment docs.

@biojppm biojppm force-pushed the emit branch 4 times, most recently from fae689f to 05a71d4 Compare January 18, 2022 12:42
@biojppm biojppm marked this pull request as ready for review February 1, 2022 23:55
@biojppm biojppm merged commit 580d1c7 into master Feb 1, 2022
@biojppm biojppm deleted the emit branch February 1, 2022 23:55
@captain-yoshi
Copy link
Contributor

captain-yoshi commented Jul 27, 2022

Just giving feedback for _WIP_STYLE_FLOW_SL:

_WIP_STYLE_FLOW_SL = c4bit(14), ///< mark container with single-line flow format (seqs as '[val1,val2], maps as '{key: val, key2: val2}')

// Is this an error ? There should be a space between values like for the map. '[val1, val2]'

You could even have these 2 styles :

# _WIP_STYLE_FLOW_SL
[val1, val2]

# _WIP_STYLE_FLOW_SL_COMPACT
[val1,val2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants