Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust matching to be more consistent to Emperor/Empress #296

Open
fedarko opened this issue Apr 10, 2020 · 0 comments
Open

Adjust matching to be more consistent to Emperor/Empress #296

fedarko opened this issue Apr 10, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request interoperability Making Qurro work well with other bioinformatics tools

Comments

@fedarko
Copy link
Collaborator

fedarko commented Apr 10, 2020

See this thread -- basically, this would mean being more conservative about filtering stuff out of the table if it isn't already in the metadata (requiring the user to specify a --filter-missing-samples flag or something to do so). This would also apply for filtering out features in the table that aren't in the rankings (requiring the user to specify a --filter-missing-features flag or something).

We could either filter missing samples/features (as is done now) or assign it "placeholder" data. In the context of Qurro I think filtering makes more sense, hence naming these flags --filter-* instead of --ignore-*. But up to debate.

The current behavior in Qurro is just filtering the table and metadata as needed, while Emperor and Empress are somewhat more cautious.

This would technically be a backwards-incompatible change, so worth updating documentation / being careful to make the new UI intuitive for users.

Based on conversation with @ElDeveloper (thanks!) :shipit:

@fedarko fedarko added the enhancement New feature or request label Apr 10, 2020
@fedarko fedarko self-assigned this Apr 10, 2020
@fedarko fedarko added this to the By next lab meeting talk milestone Apr 14, 2020
@fedarko fedarko modified the milestones: v0.7.0, Priority Tasks Apr 28, 2020
@fedarko fedarko added the interoperability Making Qurro work well with other bioinformatics tools label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request interoperability Making Qurro work well with other bioinformatics tools
Projects
None yet
Development

No branches or pull requests

1 participant