Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numerator cutoff is slightly off in proportion_plot #275

Open
mortonjt opened this issue Mar 27, 2019 · 2 comments
Open

numerator cutoff is slightly off in proportion_plot #275

mortonjt opened this issue Mar 27, 2019 · 2 comments

Comments

@mortonjt
Copy link
Collaborator

From this forum post: https://forum.qiime2.org/t/gneiss-picking-up-of-meaningful-balances/8909/5

It looks like the numerator / denominator cutoff is slightly off -- here Bifidobacter should be in denominator - but in the plot, it looks like it is in the numerator.

@mortonjt mortonjt changed the title numerator cutoff is slightly off numerator cutoff is slightly off in proportion_plot Mar 27, 2019
@justinshaffer
Copy link

@mortonjt - Thanks! If this is directly related to the dark- vs. light-blue shading cutoff in the plot, it is a bit misleading and I think should be fixed. In the example provided, it looks like 11/20 taxa are binned into light-blue (numerator) whiel only 9/20 into dark-blue (denominator). Probably a [simple] fix with the cutoff for inclusion in either dark- vs. light-blue?

CC: @fedarko

@fedarko
Copy link

fedarko commented Apr 1, 2019

@mortonjt Justin and I think we may have narrowed the problem down to around this region of q2-gneiss' codebase. The comment about "overriding the default colors in the numerator / denominator" seems a bit suspicious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants