You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
... slows things down a lot, because string comparisons are slow.
There are many possible ways we could handle this (better algorithms / data structures in JS, preprocessing stuff in Python, etc.) -- it's probably most important right now just to implement something that fixes this, since this is a pretty significant bottleneck.
The text was updated successfully, but these errors were encountered:
Just making a record of this here so we don't forget it. (@kwcantrell and @ElDeveloper did all the work of finding this!!!)
Relates to the tree shown in this twitter thread. Basically, when there are a ton of node names, this block of code:
empress/empress/support_files/js/empress.js
Lines 463 to 472 in 1b7a8d3
... slows things down a lot, because string comparisons are slow.
There are many possible ways we could handle this (better algorithms / data structures in JS, preprocessing stuff in Python, etc.) -- it's probably most important right now just to implement something that fixes this, since this is a pretty significant bottleneck.
The text was updated successfully, but these errors were encountered: