Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to adjust amount of separation between first barplot layer and the farthest tip #453

Closed
fedarko opened this issue Nov 24, 2020 · 0 comments · Fixed by #464
Closed
Assignees
Labels

Comments

@fedarko
Copy link
Collaborator

fedarko commented Nov 24, 2020

Brought up by @gwarmstrong at this morning's meeting.

Having the ultrametric PR in, as well as #366 and #308 in, definitely reduces the need for this -- but if demand for this remains in the future we may want to work on it.

For reference, a solution to this issue would involve adding an extra <input type="number"> to the barplot section of the side panel that allows users to configure the 1.1 value listed here (or something similar -- there is probably a more user-friendly way of exposing this functionality):

// Add on a gap between the closest-to-the-root point at which we can
// start drawing barplots, and the first barplot layer. This could be
// made into a barplot-panel-level configurable thing if desired.
// Currently, the 1.1 term here means that the barplots start at the
// max displacement plus 1/10th of the max displacement. If we used
// a 1.0 term instead, then barplots would start immediately at the max
// displacement (this looks kinda bad because the node circle of the
// tip(s) at this max displacement are partially covered by the
// barplots, so we don't do that).
var maxD = 1.1 * this._maxDisplacement;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants