Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up node selection #318

Open
fedarko opened this issue Aug 10, 2020 · 4 comments
Open

Speed up node selection #318

fedarko opened this issue Aug 10, 2020 · 4 comments

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 10, 2020

Currently, a problem when visualizing really big trees (~200k tips) is that there's a delay of a few seconds between clicking on a node and seeing the selection menu pop up. From talking with @ElDeveloper this morning, it would be nice to speed this up.

The current code for finding the closest node to a mouse click checks all the nodes in the tree, so if we could quickly rule out a bunch of these nodes then that'd be nice :)

@wasade
Copy link
Member

wasade commented Aug 10, 2020

What about computing quadtrees over the tip coordinate positions? It should then be possible to use the x/y position of the mouse to get the set of tips present in a small portion of the screen

@fedarko
Copy link
Collaborator Author

fedarko commented Aug 10, 2020

Would definitely be a cool idea! I think Yoshiki and Kalen were discussing binary searching as another possible method?

@wasade
Copy link
Member

wasade commented Aug 10, 2020

It's kinda like a 2D binary search :)

@wasade
Copy link
Member

wasade commented Aug 12, 2020

@zoechallacombe, this is the issue I mentioned on our call where quadtrees may be beneficial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants