-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Graphical Artifacts In SVG + PNG Exports #736
Comments
Lines bordering the triangles appear to match background color. |
Users also don't understand why the red sphere is surrounded by a black halo when the background is white. That is the expected behavior of our current lighting parameters, but could potentially be addressed by setting our ambient lighting as a function of the background color. |
The problem stems from the SVGRenderer. This object draws each individual polygon, instead of say a whole geometry. This has many downsides, as you can tell. Perhaps we could re-write a version of the SVGRenderer that draws whole geometries instead of each polygon in the scene. Although it is still experimental, exporting as a vega document remediates several of these issues.
This is a great idea, I hadn't though about that. I would love to see how things look under different lightings. |
This issue was brought to my attention by Pedro.
Viewing either png or svg exports results in white lines (could potentially be background color lines) along the borders of each triangle. Further, both the svg and png exports are flat shaded rather than smooth shaded.
The lines visible on spheres (and also on all other shapes) correspond to the exact triangles being drawn by OpenGL underneath.
The text was updated successfully, but these errors were encountered: