Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve installation of quast, spades #7

Open
agarwal opened this issue Jan 28, 2016 · 1 comment
Open

improve installation of quast, spades #7

agarwal opened this issue Jan 28, 2016 · 1 comment

Comments

@agarwal
Copy link
Member

agarwal commented Jan 28, 2016

There are a few ways the quast package could be improved:

  • Separate build versus install. Opam has for some time supported a separate install phase, and install steps are recommended to go there. Right now opam-build.sh does both, so this file could be split into two. But also, next points suggest avoiding the shell script altogether.
  • Can we assume users of packages installed with opam will have opam installed? Seems like a reasonable assumption unless you're planning to move a generated .opam directory to a different computer. If so, the script quast that is being generated could be a static file; replace $PREFIX with opam config var prefix.
  • Can the .install file be generated in advance? The new biopam-dev tool may help. I'm moving towards statically generating .install files as much as possible. It makes it more transparent what will be done. I'm even providing different install files for different OS's, e.g. see how the updated ncbi-vdb package does it.
@agarwal agarwal changed the title improve quast installation improve installation of quast, spades Jan 29, 2016
@agarwal
Copy link
Member Author

agarwal commented Jan 29, 2016

The comments about quast also apply to spades. We should settle on some packaging best practices and document them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant