Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional prom CounterValue metric for peer flaps #481

Open
bartdorlandt opened this issue Nov 7, 2024 · 0 comments
Open

Additional prom CounterValue metric for peer flaps #481

bartdorlandt opened this issue Nov 7, 2024 · 0 comments

Comments

@bartdorlandt
Copy link

Describe the feature
Besides having the stateDesc providing the exact peer state at a moment in time, I'd like to see a metric (type CounterValue) that is increased every time a BGP peer flaps. Allowing to see increases also in between prometheus scrapes.

Use cases / additional context
The stateDesc (file: bio-routing/bio-rd/metrics/bgp/adapter/prom/bgp_prom_adapter.go) will provide the current state at the moment of scraping. Most probably providing it with a value of 0 or 6 (Down or Established).
Though flaps in between those state are only see if the flap takes longer than the prometheus scrape time.

A flap down would add 1 to the counter as well as a flap up.

The metric would need the label for the peer IP as well, to show which peer has flapped. Probably along with the local AS, peer AS and VRF as it is currently done in the collectForPeer().

@bartdorlandt bartdorlandt changed the title Additional prom metric for peer flaps Additional prom CounterValue metric for peer flaps Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant