Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Function Arguments #47

Closed
MSiggel opened this issue Feb 23, 2018 · 2 comments
Closed

Generate Function Arguments #47

MSiggel opened this issue Feb 23, 2018 · 2 comments

Comments

@MSiggel
Copy link
Contributor

MSiggel commented Feb 23, 2018

Currently we generate individual datreants and folders with

def write_bench(top, tmpl, nodes, gpu, module, tpr, name, host, time):

the tpr argument is very gromacs specific and should be removed in the future once NAMD is implemented. It currently does not impair the code but is unused in the when running this for NAMD.

@mimischi
Copy link
Contributor

The tpr argument was only added recently. We pass the name of the corresponding tpr file to write_bench, after ensuring that it actually exists. In regards to #29: we could already solve this issue in there.

@mimischi
Copy link
Contributor

mimischi commented Apr 4, 2018

This issue will be solved when #49 is merged.

def write_bench(top, tmpl, nodes, gpu, module, name, host, time):

def write_bench(top, tmpl, nodes, gpu, module, name, host, time):

But generally we should keep in mind to simplify the code and try to merge the two write_bench functions into one generalized function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants