Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generate work with relative file paths #124

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Make generate work with relative file paths #124

merged 3 commits into from
Oct 24, 2018

Conversation

mimischi
Copy link
Contributor

@mimischi mimischi commented Oct 23, 2018

Fixes #120.

Changes made in this pull request:

  • Fixed a bug, where running mdbenchmark generate --name ../md.tpr would copy the file md.tpr to the wrong destination folder.
  • Fixed a bug where specifying mdbenchmark generate --name md.namd would not parse the file name correctly.

PR Checklist

  • Added changelog fragment in ./changelog/ (more information)?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #124 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #124      +/-   ##
===========================================
+ Coverage    96.12%   96.15%   +0.03%     
===========================================
  Files           14       14              
  Lines          723      729       +6     
===========================================
+ Hits           695      701       +6     
  Misses          28       28
Impacted Files Coverage Δ
mdbenchmark/mdengines/gromacs.py 100% <100%> (ø) ⬆️
mdbenchmark/mdengines/utils.py 100% <100%> (ø) ⬆️
mdbenchmark/generate.py 100% <100%> (ø) ⬆️
mdbenchmark/mdengines/namd.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742c5c4...ec6b59b. Read the comment docs.

@mimischi mimischi merged commit 70b9e02 into develop Oct 24, 2018
@mimischi mimischi deleted the copyinput branch October 24, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant